py: use subprocess to read with timeout #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mkoeppe please check before we merge this.
./py/test/test.sh
looks goodpreviously i wanted to avoid "subprocess to read with timeout"
but starting a new python interpreter from python uses almost no extra memory
because the python executable is shared memory
so this uses even less memory than calling the
dd
executable (5MB RSS)same python interpreter instance running multiple scripts simultaneously
pros:
os.dup(self._fdRead)
blocking
os.read
is guarded by timeout of subprocess→ fix py: fix read with timeout on windows #10
→ js: fix read with timeout on windows #6
cons:
_parse_exception
is needed to handle unexpected errors from the python subprocess